Mel bold changes#438
Draft
ganeshvanahalli wants to merge 5 commits into
Draft
Conversation
Combines the 'edit' fix with feat/mel-osp-changes (6fd6ad4), which refactored ExecutionContext to {targetParentChainBlockHash, initialWasmModuleRoot}. Passes both as HashZero for the proof fixtures and drops the now-unused inboxLimit/bridge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
OneStepProverHostIo now takes (customDAValidator, hashProofHelper); the deploy script only passed one arg, failing hardhat-deploy with "expected 2 constructor arguments, got 1" and breaking the OneStepProof proof-validation tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Non-MEL halted proofs serialize only the global state (the prover reads no further), so unconditionally deserializing a MELState ran past the proof end and reverted with Panic(0x32) for every terminal step. Gate the MELState read and kickstart logic on a non-zero MELStateHash. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR by @rauljordan with full credit.